Game breaking bug (only 1) - defeted empires/pirates still ingame - hope to get highest priority (savegames/screenshot)

[fruitgnome]

1. Defeated empires (0 colonies)/pirates (0 spaceport/0 construction ship) stay in game.
I think the "new empire/pirate is discovered" get fired a second time.

Easiest solution after loading game (as workaround):
Run script delete defeated empires/pirates

[MaximKI]

We've fixed this multiple times but it looks like the not all cases have been addressed. Please upload a save from ideally before and after you noticed the empires and pirates not getting removed after defeat.

[fruitgnome]

Here is a save after defeating shakturi:

defeated.7z

(7.64 MiB) Downloaded 3 times

It is not reproducable by savegames before. I tried with some savegames before but the shakturi are wiped out.
But here is one before invasion, 7th fleet is flying to invade (hotkey 1). Only let the game run.

before_invasion.7z

(7.61 MiB) Downloaded 3 times

As I wrote event "new empire encountered" is fired:

Screenshot 2024-11-12 200606.png (2.19 MiB) Viewed 145 times

I played on speed 8x. 300 stars only. Beta 1.2.7.1 (latest).

In the saves you can also see that ghost fleet although defeated is still ingame.

Edit: btw stuck jumping fleets are also not repreducable by savegames.

[MaximKI]

Thanks for the saves. Do you happen to have a save from before the ghost fleet gets eliminated?

[fruitgnome]

No, because I notice that a pirate fleet still lives almost all the time much later. And you don't need a savegame for this, it's the same that the event "xxx encountered" as by empires. And check also because I think the event can also be fired by other empires not only by the player empire. I'm sure if Elliot hears abot a bug he can check the code.

I'm a programmer.

If event "xxx encountered" is fired check at pirates:
if (count(spaceports) === 0) break;
at empires:
if (count(colonies) === 0) break;
else add empire to empire list

[fruitgnome]

What I really do not understand is that the empires get deleted in game editor but not in real ingame.

Pls let defeated empires and pirates in game editor -> endless mode